Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Default function for schemas #26

Merged
merged 43 commits into from
Nov 28, 2024
Merged

Add Default function for schemas #26

merged 43 commits into from
Nov 28, 2024

Conversation

LswaN58
Copy link
Member

@LswaN58 LswaN58 commented Nov 6, 2024 •
edited
Loading

Resolves #1

LswaN58 added 30 commits October 16, 2024 09:16
@LswaN58
Add an abstract 'Default' property to Schema base class, so all other…
714bbff 
…s have to implement.
@LswaN58
Merge branch 'main' into issue/1-add-defaults-for-schemas
832a708
@LswaN58
Duh, should be a classmethod, not a property.
7a00c72
@LswaN58
Modify earlier 'DEFAULT' prototype to match new 'Default' required by…
80c8e2c 
… base class.
@LswaN58
Add a placeholder Default function to IndexingSchema.
d3d5abd
@LswaN58
Merge changes from main.
096369b
@LswaN58
Remove an empty line.
23cb82b
@LswaN58
Missed a place where DEFAULT should become Default.
c446574
@LswaN58
Merge changes from main.
04c26a1
@LswaN58
TestConfigSchema should use Default, not DEFAULT.
5c1603f
@LswaN58
Default should return class instance, not Self, apparently. Self does…
c36723e 
…n't seem to be a very useful hint.
@LswaN58
Add an init for the test config folder.
e2d5221
@LswaN58
Since we're not using Self hint, remove its import.
faa22e0
@LswaN58
Add Default() to each of the data source schemas.
cfeb0b1
@LswaN58
Add default for config-related schemas.
3f2e464
@LswaN58
Use defaults in the FromDicts.
4d4568c
@LswaN58
Set up dataset-related schemas with Default().
f72d65b
@LswaN58
Add some todos for better ways of doing FromDict and ElementFromDict.
f59c55d
@LswaN58
Missed a Default() for a class in FileListSchema module.
68e40fc
@LswaN58
Add defaults for table schemas.
1388adb
@LswaN58
Add a basic default for AggregateSchema, but so far without content.
a9b7a53
@LswaN58
Merge changes from masater.
189fc0c
@LswaN58
Some changes missed when switching FromDict to use cls.
f727123
@LswaN58
Convert some FromDicts to use cls instead of full class name.
18166f0
@LswaN58
Add default to DataElementSchema.
0774ebd
@LswaN58
Have DataElementSchema use defaults in FromDict.
e49eeff
@LswaN58
Add defaults for DetectorSchema and DetectorMapSchema.
52775cf
@LswaN58
Turn f-strings with no params to regular strings.
173b5d8
@LswaN58
Turn another f-string with no params to regular string, and remove un…
9398ad0 
…used imports.
@LswaN58
Add defaults for EventSchema and FeatureMapSchema.
0a1a4d7
@LswaN58 LswaN58 added the new feature New feature or request label Nov 6, 2024
@LswaN58 LswaN58 self-assigned this Nov 6, 2024
@LswaN58 LswaN58 linked an issue Nov 6, 2024 that may be closed by this pull request
Add "Default" for each schema class #1
Closed
@LswaN58 LswaN58 merged commit bc4f622 into main Nov 28, 2024
16 checks passed
@LswaN58 LswaN58 deleted the issue/1-add-defaults-for-schemas branch November 28, 2024 16:18
@LswaN58 LswaN58 added this to the ogd-common 2.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LswaN58 LswaN58

Labels
new feature New feature or request
Projects
None yet
Milestone
ogd-common 2.0 "refactor"
Development

Successfully merging this pull request may close these issues.

Add "Default" for each schema class
1 participant
@LswaN58